Support size ranges - Githubissues

bbdoc / PoracleWeb

Web Interface add-on to PoracleJS

GNU Affero General Public License v3.0

21 stars 33 forks source link

Support size ranges #155

Open kamieniarz opened 11 months ago

kamieniarz commented 11 months ago

I decided to fix an ugly issue with sizes I described here: https://discord.com/channels/358180805031493634/786241014037741609/1150152266012184659

Pros:

[new] users can select min. and max. sizes on add page and edit modal
[fix] when someone tracks everything there's no more XXS label (no label to be more specific) - edit modal has ALL selected

Cons:

no validation for cases where size>max_size - just a warning instead
code is proly bad quality - I have no idea what I'm doing but it works ;)

bbdoc commented 11 months ago

I'll keep this open while I'm thinking about the best way to implement those changes.

I have already updated the display part, so could you please revert your changes to it and pull the latest changes.

Thanks