Closed jepke closed 3 years ago
You need an if isset
around your new block as well as default to 1 if not set (maybe an hidden input) as I think lots of people won't need it.
Then you also need to update modal so people can update it as well.
That's why i added WIP title tag
yep no problem, just mentionning so you don't forget it ;-)
btw I see in your current dev you only set $allowed_templates in config, but some people might have different templates for raids/quests/pokemons... we might need different config options for each.
Hi,
What's the status of this PR ? Could you please rebase as there have been quite some commits in between. I guess it's also needed for invasions tracking.
My main comment about the PR is that you only have one config for $allowed_templates
but what if people want to use different templates for pokemons / raids / quests / invasions ? Shouldn't you have one config option per type ?
Did you manage to get feedback on the styling part ?
Thanks
Hi,
What's the status of this PR ? Could you please rebase as there have been quite some commits in between. I guess it's also needed for invasions tracking.
My main comment about the PR is that you only have one config for
$allowed_templates
but what if people want to use different templates for pokemons / raids / quests / invasions ? Shouldn't you have one config option per type ?Did you manage to get feedback on the styling part ?
Thanks
It's all split up now. Styling is still a thing imo very minor.
Is this ready to be merged ? I didn't get any feedback from testing yet.
I've been using it since I build it no issues
Needs more to finish it up but made the start.