search

bbdoc / PoracleWeb

Web Interface add-on to PoracleJS
GNU Affero General Public License v3.0
21 stars 33 forks source link

settings are saved, even when not choosing to save #56

Closed philcerf closed 3 years ago

philcerf commented 3 years ago

Hey.

In the settings dialogue, if one changes a setting and leaves it without storing (e.g. via ESC), the setting seems to be still saved.

Cheers

bbdoc commented 3 years ago

There is no way settings could be saved with pushing the update button... it's a form action so if you don't click it won't start updating anything in DB. The only thing that is updated as soon as you click are languages...If you close and reopen the dialog without refreshing the page, it will still show your selection as it's the same page, but that's normal behaviour. Doesn't mean anything has been updated if you didn't click the update button.

Please describe EXACTLY your issue when you have one, and please first mention it on discord before opening issues on non-confirmed behaviour on GitHub.