search

bbecquet / Leaflet.PolylineDecorator

A plug-in for the JS map library Leaflet, allowing to define patterns (like dashes, arrows, icons, etc.) on Polylines.
MIT License
492 stars 115 forks source link

Fix for calling _initPatterns #71

Closed Techn1x closed 6 years ago

Techn1x commented 6 years ago

Not sure why this commit has so many lines changed in the diff, but the only change was the following line; this._patterns = _initPatterns(this.options.patterns); to this._patterns = this._initPatterns(this.options.patterns);

Not sure why it was missing this to begin with but I've added it since even though it was working previously, it seems to throw an error in Ember.js 2.17.0-beta.2

bbecquet commented 6 years ago

Hi! Thanks for this PR. The this should be here indeed, so that's actually a bug. The big diff is probably due to line breaks inconsistencies in the included plugin (that's the code of https://github.com/bbecquet/Leaflet.RotatedMarker) that your editor removed, no big deal.

The main problem is that you edited the dist file directly, whereas you should modify files in src and then use rollup build dist with the npm run build command.

Sorry, I know this is explained nowhere. I should 1) write at least some guidelines for that 2) just probably remove the dist file from versioning completely, even if it would make the project more complicated to use for people who don't use npm. I still haven't decided…

In the meantime, can you please modify the PR to edit src/L.PolylineDecorator.js instead? If you have done npm install in the project, you should be able to launch npm run build, which will generate the new file in dist for you (and the big diffs should disappear also).

Thanks!

Techn1x commented 6 years ago

Sure! I'll do it as a new PR though

Link to new PR; https://github.com/bbecquet/Leaflet.PolylineDecorator/pull/72