search

bbenefield89 / PythonAlarm

A CLI to set alarms
MIT License
2 stars 4 forks source link

Add ability to set alarm from command #26

Closed chatpion closed 6 years ago

chatpion commented 6 years ago

Add optional parameter given_time in pylarm to support alarm from CLI.

bbenefield89 commented 6 years ago

Hi @ChatPion thanks for taking an interest in Pylarm.

A lot of this looks great but for consistency reasons, I would prefer if users were able to set their alarm without having to specify a meridiem.

You are more than welcome to add this functionality to include a meridiem but by default I would prefer it without.

chatpion commented 6 years ago

In the original issue (#19) an example with a meridien was added, but I can remove it if you want. I'll try a fix to only evaluate times

chatpion commented 6 years ago

I don't know if I should check whether the input is a valid hour in 12 hours format or that should be done in pylarm.py

bbenefield89 commented 6 years ago

@ChatPion thanks for the awesome work! We couldn't have done it without you.

As soon as I can, I will add you to the contributors list.

If you would like to see your name up there even faster though, you are free to make a new PR from a different branch that adds you to the list in the README.md.

If you decide to make another PR just be sure to use the PR template this time.