search

bbengfort / django-generic-json-views

Class based generic views that render JSON data.
Other
31 stars 17 forks source link

Support for Python 3 and Django 1.8 #13

Closed lukasklein closed 8 years ago

lukasklein commented 9 years ago

According to https://docs.djangoproject.com/en/1.8/topics/python3/#string-handling, force_unicode has been renamed to force_text.

lukasklein commented 9 years ago

This is not ready for merge, yet.

bbengfort commented 8 years ago

@lukasklein Thanks for taking a crack at these updates, I haven't merged because you said it wasn't ready for merging yet. However, @philippbosch has just contributed some python 3 compatibility stuff, that does look like it's ready. If you want, maybe check those out and see how they fit in with what you were doing?

philippbosch commented 8 years ago

Ooops, I should have looked at the open PRs first before creating a new one … Sorry

bbengfort commented 8 years ago

@philippbosch no problem - this pull request is old, and he mentioned it wasn't ready yet. I think I'll just go with yours; I'll have some time after the new year to get everything tested and pushed

lukasklein commented 8 years ago

Hey there, thanks @philippbosch for your efforts. @bbengfort is right, my PR never got beyond a "works for me" alpha.

bbengfort commented 8 years ago

@lukasklein - thanks for getting back! I'll take a look at what you were doing when I swing back to this and make sure it's at least compatible, then I'll push @philippbosch to PyPI.