search

bbenligiray / stag

STag: A Stable Fiducial Marker System
MIT License
188 stars 52 forks source link

Source Code not Compatible with Opencv 4 higher #29

Closed entcat closed 10 months ago

entcat commented 1 year ago

Hi,

I am trying to build the source on my windows system and i have a opencvconfig,cmake file from my opencv 4.x.x build. As i am looking at the source code, i can see there are lots of #ifndef BUILD_MACOS provided and some files are even using highly deprecated headers like opencv/cv.h, can you please make the source opencv 4 and higher compatible along with windows ?

Thanks.

bbenligiray commented 1 year ago

lots of #ifndef BUILD_MACOS provided

So if you define that it will build for macOS (though I wouldn't know, I didn't try myself), but otherwise this codebase is meant to be compiled on Windows

deprecated headers like opencv/cv.h

That's because ED and EDLines are implemented in C

Sorry, my current commitments prevent me from maintaining this codebase, including reviewing any PRs. I'd recommend building with OpenCV 3.1 as a library and using whatever OpenCV version you want in your own project.

ManfredStoiber commented 11 months ago

Hi there, I created an updated fork of this repository which is compatible with OpenCV 4, available here.

@bbenligiray Since you mentioned that you won't be able to maintain this codebase, I decided to create a fork which I will keep updated and implement some more functionality. If you want me to create PRs for this repository instead, please let me know.

Best regards

bbenligiray commented 10 months ago

Hey @ManfredStoiber, thanks for the offer but I think me being involved will only slow things down. You have my full blessing to maintain your fork and feel free to open a PR to update the README here to notify people of your fork.

ManfredStoiber commented 10 months ago

I understand that. Thank you very much! I created a PR for the README as you suggested.

bbenligiray commented 10 months ago

Closed by https://github.com/bbenligiray/stag/pull/33

HRS-Soumya commented 10 months ago

I understand that. Thank you very much! I created a PR for the README as you suggested.

Hi @ManfredStoiber. I tried building the library on windows using Cmake but i am getting an error where 'LibStag.lib' is not getting generated. I am facing the same error using cmake gui as well as the executeable.

ManfredStoiber commented 10 months ago

Hi @HRS-Soumya,

I was able to reproduce your problem and fixed it. Please try again with the new version and let me know if it worked.

HRS-Soumya commented 10 months ago

Hey @ManfredStoiber The build issue is resolved. But I found out that the release and the debug libs have the same name. Generally the debug libs have the name $name$d.lib and the release libs have the name $name$.lib. Also no staglib.dll file got generated. Can i add this library to my project without a dll file for this library ?

HRS-Soumya commented 10 months ago

Nvm. It is working as expected. You created a static lib so the .dll file was not required. Thanks @ManfredStoiber.

ManfredStoiber commented 10 months ago

Great! For Windows I added the "d"-Postfix for the library when compiled in debug mode, as you suggested. You're right, the library is created as static by default, but I added the possibility to create as shared library when using the cmake option "BUILD_SHARED_LIBS=ON".

bbenligiray commented 9 months ago

(@ManfredStoiber consider enabling issues at your repo)

ManfredStoiber commented 9 months ago

Thanks for the hint, I enabled it. Did not know it wasn't enabled by default.