search

bberak / react-native-game-engine

A lightweight Game Engine for React Native 🕹⚡🎮
MIT License
2.89k stars 174 forks source link

Fixes Functions not in TS definition files #60 #61

Open SimpleProgrammingAU opened 3 years ago

SimpleProgrammingAU commented 3 years ago

As I am new to using react-native-game-engine I am not 100% that all of the correct functions have been exposed. Please review the changes I have made to ensure they match the expected use of the library.

drplauska commented 2 years ago

@bberak what's the situation for this pull request? is something missing? I'm willing to participate

bberak commented 2 years ago

Much appreciated @drplauska,

I think we just need someone who is comfortable with TS to verify that this PR won't break backwards compatibility.

Also, I think we need to rename the following types:

Then update the GameEngineProperties interface to use the new type names (Timer, Renderer).

drplauska commented 2 years ago

@bberak this doesn't look too bad, merging this shouldn't cause issues with backwards compatibility. What would you say about rewriting the lib with typescript? It wouldn't be necessary to maintain type declaration and the project would be easier to jump into for new people I could work on that, but would probably need a little bit of consulting

bberak commented 2 years ago

Hey @drplauska,

Really appreciate your reviews and comments 🙏 . I'm definitely not against rewriting the lib with typescript. I'd probably review the overall design of the components at the same time and perhaps opt for moving to something a bit more modern using hooks and functional components. I'm certainly open to any contributions if you're interested 👍.

drplauska commented 2 years ago

@bberak I'm gonna try and rewrite the lib asap

bberak commented 2 years ago

Hi @drplauska,

Perhaps we should just fix up the types in this PR first - to unblock people who might be relying on TS?

I'll get in touch regarding a full rewrite (I got your email btw 👍)

shreykul commented 1 year ago

Hi @bberak, This seems like a very good lib and it'd be really great if it could be maintained. Was there any conclusion to the above conversation?

bberak commented 1 year ago

Hey @shreykul

I just need to sit down and work through this PR to make sure it's working as expected.. Seems like TS support is becoming more essential for adoption these days.. I'll try work through it over the weekend; and also maybe update the handbook repo to work with the latest version of Expo..

shreykul commented 1 year ago

@bberak that'd be really great!! Can I try updating the handbook repo with typescript? I'm trying to learn typescript so it'd be a great project for me...

esphung commented 10 months ago

Hey guys, I can help too if you want I'm not new to react native or Typescript but I am trying to use this library seriously. I ran into some things that I made a patch for, but could probably fix if you need the extra set of hands. Let me know if you need help.

I can also just submit PRs. I wasn't sure if this repo was maintained because there hasn't been in update in a while

bberak commented 10 months ago

Hey @esphung 👋,

Thanks for offering to help. I'm happy to accept PRs (especially around updating/adding typing information). Also happy to chat about any other issues you ran into..

Cheers,

Boris

esphung commented 10 months ago

Can you inv me? I tried to make one but I couldn't because I want a member on GH