search

bbernhard / qt-android-docker

build a Qt android app inside a docker container
13 stars 3 forks source link

Fix build for Debian 10 #1

Closed homdx closed 5 years ago

homdx commented 5 years ago
bbernhard commented 5 years ago

Thanks a lot for the pull request - very much appreciated!

I saw that you replaced the benlau/qtci dependency with your own fork of the repo. I guess that's because of this pull request here (which isn't yet merged), right? https://github.com/benlau/qtci/pull/27

homdx commented 5 years ago

Yes. Because I have a newer version in my repository. So I had to replace the links to my fork.

If you want to merge, I will be recommit again, with restore you links and rebase it commit

bbernhard commented 5 years ago

Looks good to me!

Not sure if/when @benlau will merge your changes upstream. But if he does, could you maybe do me a favor and create another pull request that changes the dependency back to the upstream repository? That would be really great.

In general I am in favor of keeping the dependencies pinned to the upstream repository. But as your pull request is not yet merged into benlau's repository, I think it's perfectly fine if we merge that pull request in the meantime.

Thanks again for your contribution!

homdx commented 5 years ago

Hello. Have a nice day!

I did the adaptation work for usage : Clang with debian and update to Qt 5.13.1 version. You need my pull request for another branch (or for master branch) after then I rebased commits? https://github.com/homdx/qt-android-docker/tree/513

bbernhard commented 5 years ago

Hi,

sorry for the late reply!

Could you maybe create another pull request for your changes? (master branch is fine) That makes it easier for review :)

Thanks a lot!

homdx commented 5 years ago

Hi,

sorry for the late reply!

Could you maybe create another pull request for your changes? (master branch is fine) That makes it easier for review :)

Thanks a lot!

Hello again) I I have three options:

  1. Some modified default scripts and update from 5.12 to 5.13 version of Qt https://github.com/homdx/qt-android-docker/tree/513

  2. Script with long setup: Qt 5.13.1 and recompile it from sources with Clang to armv7 architecture with openssl recompile from sources too and remove setupped Qt 5.13 and usage you recompiled version (need 20 Gb hard disk space for image and 2-4 cpu from compile 90-120 minutes for build this image) https://github.com/homdx/qt-download-2/blob/master/Dockerfile.fullsrc

  3. Script and docker image for usage this version (maked on step 2): compressed docker size 4 Gb or 2Gb for slim image https://github.com/homdx/qt-download-2/blob/master/Dockerfile.prebuild Or example from docker hub https://github.com/homdx/qt-sources-android/blob/master/Dockerfile

I did not confuse you?

bbernhard commented 5 years ago

Cool, wasn't aware that you've created multiple versions - very nice!

I think option 1 would be perfect for this. :+1:

Thanks for sharing the other versions too - looks really nice!

homdx commented 3 years ago

Hello @bbernhard I make Dockerfile and scripts for build Qt dev from sources for Android (branch later then Qt 6.0.0 released). Are you interested this? Make the pull request for you? You can sea it at master branch and dev in my forked repository.