search

bbg-cookbooks / monit-ng

chef cookbook for installing/configuring monit from package or source, with resource provider for managing monit checks
https://github.com/bbg-cookbooks/monit
Apache License 2.0
12 stars 35 forks source link

Add Monit Disk Resource #41

Open tylernisonoff opened 9 years ago

tylernisonoff commented 9 years ago

allows one to alert on disk space usage.

nathwill commented 9 years ago

this seems to refer to a template that doesn't exist; did it get missed in the commit?

tylernisonoff commented 9 years ago

ah sorry about that -- I tried picking out individual files from another branch that I had a bunch of other changes on and missed the template. I'll add a commit.

tylernisonoff commented 9 years ago

any update on these PRs?

nathwill commented 9 years ago

yeah, sorry for the delay, i've been somewhat busy, and also wanted to take some time to digest this, since it's a new way of managing monit checks (new resources instead of attributes).

to explain, it's been a part of the long-term migration plan for this cookbook to end up with multiple resources, intended to be set up as subclasses of Chef::Resource::MonitCheck, so i don't really have any problems with this, just mostly been contemplating whether or not now is the time to start the big refactor that'll be needed to set up check-type based resources as subclasses...

i think this is a reasonable start, and fits with the long-term plan for the cookbook, so i'm OK to merge it, but i'd like to see some tests to go along with it so we can make sure not to break anything whenever there's time to dig into the next big change for the cookbook. sounds reasonable?