BorderSize +3 empty pixal rows issue

JC7897 commented 4 years ago

Hello gijsbers,

Here is the problem with CrystalBlue +3 empty pixal rows.

borderissue

The BorderSizeX and BorderSizeY controls the size of frame not the frame xpms. This means that if you put BorderSizeY = 0 you will get no added size to top and button frames even if you have a frameAB.xpm with a size of 5 pixals you will not see it because the BorderSizeY is at 0. The BorderSizeY would need to be set to 5 so you can see the 5 pixals of the frameAB.xpm. With the frameAT.xpm the BorderSizeY will start at top of frameAT.xpm and place 5 pixals on top of the frame which is different to the bottom because there is no title frame at the bottom.

gijsbers commented 4 years ago

But couldn't you use TitleBarVertOffset to overcome this problem?

#  Vertical offset for the window title text

These themes use it: CoolSteel, Crunchy-grey, Crunchy-orange, DarkT_II, IceClearlooks2, IceClearlooks2-Magi, IceNumix3-Aqua, LunaDotHome, OpenLook-shaped, Sky, Smooth_Aqua, Trisquel, lovena, motif-dark.

JC7897 commented 4 years ago

No i don't believe that will work. This is what happen if change TitleBarVertOffset +5/-5.

TitleBarVertOffset +5

TitleBarVertOffset -5

But i noticed that IceNumix3-Aqua does not have any title.xpms. He only made the frame.xpms. Could that why you are getting better frame positioning with that theme? I could try and remove the title.xpms and make just the frame but i guess that will have to wait until later on today.

UPDATE: Removing the title xpms will not work for CrystalBlue or any other theme that is using multi colors for the title bar. The reason IceNumix3-Aqua works without the title xpms is because it's using one color which i believe is set in the default.theme. If i remove the title xpms on CrystalBlue, i get a solid blue bar not a gradient, which i can only change to another solid color.

gijsbers commented 4 years ago

The theme IceNumix3-Aqua uses Look=flat. That is why it can go without title xpms. For CrystalBlue and Illuminate-ice you need a much smaller value for TitleBarVertOffset. -2, or +2 or so. Illuminate-ice is an especially suitable test theme, because it has an empty top side mask of 9 pixels!

JC7897 commented 4 years ago

This is what i got.

This what Illuminate-ice should look like.

Good

This is Illuminate-Ice with the 9 transparent pixals removed. (notice the 9 extra pixaps are on top of the titlebar)

0-T

This is Illuminate-Ice with the 9 transparent pixals removed and TitleBarVertOffset at -10.

-10-T

This is Illuminate-Ice with the 9 transparent pixals removed and TitleBarVertOffset at +10.

+10-T

The only way i found to take into account the 10 BorderSize and not use the 9 transparent pixals was to change the TitlebarHeight to 20 and keep the bordersize at 10 but there is a problem with that. The problem is that since the title bar is smaller you would need to draw half the button on the Close,Maximize,Minimize and Restore buttons and the other half of the button on the frame which can not be done. The only other option is to redo the buttons a lot smaller and changing the look of Illuminate-ice.

I think for CrystalBlue i might be able to do that without changing the look but i will need to redo the theme but i can not do that for Illuminate-ice.

gijsbers commented 4 years ago

OK, sounds good.

JC7897 commented 4 years ago

Ok i think i have corrected the issue but i did run into another issue with the workspace buttons.

This is the way i intended it to look. Which is the 1st CrystalBlue theme.

workspacebutton-good

This is how it looks like in slackware current. It looks like the spacing in the fonts changed.

workspacebutton-bad

So i made CrystalBlue-default.zip without the nice workspace buttons i made.

Try this one first. CrystalBlue.zip

But if you have issues with workspace buttons, use this one instead. CrystalBlue-Default.zip

gijsbers commented 4 years ago

Is there a version of icewm which shows your CrystalBlue.zip as your 1st CrystalBlue? None of the ones I tried did. If you want your buttons like the 1st, then you could simply add the workspace buttons as Gradients:

Gradients="menubg.xpm dialogbg.xpm workspacebuttonactive.xpm workspacebuttonbg.xpm"

There is a problem with:

DesktopBackgroundImage=                 "/usr/share/wallpapers/wallpaper-00.jpg"

This may not exist, but it may override some user setting in preferences.

JC7897 commented 4 years ago

This new one should be correct expect for the wallpaper-00.jpg. The reason i don't share the wallpaper is i did not make it and i don't know where i got the picture from.

CrystalBlue

CrystalBlue.zip

Make sure you remove the old CrystalBlue package in your /usr/share/icewm/themes location. It's provably conflicting with the CrystalBlue in your /home/user/.icewm directory.

JC7897 commented 4 years ago

Should be fix. Closing.

JC7897 commented 4 years ago

Should be fix. Closing.

gijsbers commented 4 years ago

Could it perhaps be that titleAJ.xpm, titleAQ.xpm, titleIJ.xpm and titleIQ.xpm are missing? There are some artefects on the left and right side of the titlebar.

gijsbers commented 4 years ago

There are small dots in the corners of the titlebar. See image. The buttons of the message dialog may need to become gradients? killclientdialog

JC7897 commented 4 years ago

The small dots in the corners are transparent spaces that i use to make the theme have a rounded corner. For some reason the theme appears to have lost transparency. I don't think i need the title?J and title?Q.xpms. This what i get.

Icewm-1.7.0.98. Dialog

I can add them just incase but they should not be needed. However since i see a minor color issue with buttons i try and make a new CrystalBlue download later on today.

JC7897 commented 4 years ago

You can try and see if this new version fixes the issue.

JC7897 commented 4 years ago

Sorry i forgot to fix the color issue. Try this download.

CrystalBlue.zip

gijsbers commented 4 years ago

dialog The dialog buttons are no good yet. See image. Also, the theme modifies desktop background settings, even though it doesn't provide a background image. It should leave the desktop background settings untouched. Then users can set them in their preferences.

JC7897 commented 4 years ago

The dialog buttons might look better if i add taskbuttonbg.xpm to the gradients but it's still not going to look correct. The reason is because icewm does not use a dialogbuttonbg.xpm so it just uses the taskbuttonbg. With the background image i will remove DesktopBackgroundImage="" and DesktopBackgroundScaled=1 from the default.theme.

Here is CrystalBlue.

With taskbuttonbg, taskbuttonactive and taskbuttonminimized added to gradients.
Removed DesktopBackgroundImage= "" and DesktopBackgroundScaled=1 from default theme.

CrystalBlue.zip

gijsbers commented 4 years ago

The case is that this theme doesn't provide buttonA.xpm or buttonI.xpm. The solution for the dialog buttons would be to add buttonA.xpm and buttonI.xpm to Gradients.

JC7897 commented 4 years ago

Ok here is a new CrystalBlue download.

With menuButtonA.xpm,menuButtonI.xpm,buttonA.xpm and buttonI.xpm added.
buttonA.xpm and buttonI.xpm are also added to the gradients section in the default.theme.

CrystalBlue.zip

JC7897 commented 4 years ago

Nevermind the other download i got it to upload here. Use the CrystalBlue in the post above.

gijsbers commented 4 years ago

Looks good! :+1:

If you like, you could test the new MiniIcons. Play with:

MinimizeToDesktop=1 # 0/1
MiniIconsPlaceHorizontal=1 # 0/1
MiniIconsRightToLeft=1 # 0/1
MiniIconsBottomToTop=1 # 0/1

JC7897 commented 4 years ago

I'll check it later but right now there seems to be an issue with CrystalBlue not adding the files i added on icewm-1.7.0.113. I can see the files in the icewm/lib/themes/CrystalBlue directory but when i make icewm the files are missing.

gijsbers commented 4 years ago

This should be fixed now. The titlebar corners are in some other color and have a hole: xterm-titlebar When I set Alpha=1 with compton I get this: close-xephyr and this: wmdialog The button pixmaps are too translucent?

JC7897 commented 4 years ago

This is what i get with alpha = 1 and compton. I can't replicate "The titlebar corners are in some other color and have a hole.".

CrystalBlue + Alpha 1 + Compton CB-Alpha-1-Compton

Ater-Ice-Hybird + Alpha 1 + Compton Ater-ice-hydrid-Alpha-1-Compton

I don't know why some xpms are transparent while others are solid color. I made the xpms in gimp.

BTW: If i try switch icewm themes with compton on the screen sometimes keeps flickering and will not load the icewm. Not sure if this is related but i did see this in my logs when i hit CTRL+ALT+Backspace.

01:26:16.922: icewm-session: icewm exited with status 1.

https://pastebin.com/1E0Sz8FH

JC7897 commented 4 years ago

The transparency issue has to do with gradients. I made an issue here about it.

https://github.com/bbidulock/icewm/issues/468

JC7897 commented 4 years ago

Hey i see a bit of a color issue with the close.xpm. This should fix slightly different color with the close.xpm.

close