bbidulock / icewm

A window manager designed for speed, usability, and consistency
Other
590 stars 100 forks source link

Wrong font for buttons since 6d557213227ea4952f7fe2f6b547bb26e8e8523c #484

Closed targzeta closed 4 years ago

targzeta commented 4 years ago

Hi, I have this prefoverride:

ActiveButtonFontNameXft    = "ArcadeAmerica:size=9:bold"
NormalButtonFontNameXft    = "ArcadeAmerica:size=9"

Before the commit 6d557213227ea4952f7fe2f6b547bb26e8e8523c my workspace buttons were like that bb1ee19a965cf6d271936de7f641b822dbf36760 now, instead, are like that: 6d557213227ea4952f7fe2f6b547bb26e8e8523c

Thank you in advance, Emanuele

gijsbers commented 4 years ago

Yes, if you do:

$ grep WorkspaceFontNameXft  preferences
# NormalWorkspaceFontNameXft="sans-serif:size=12"
# ActiveWorkspaceFontNameXft="sans-serif:size=12"

You see that that there also exists fonts specially for the workspace buttons. In issue #475 a theme designer requested that they actually be used. Commit 80c5b4af3f9d4e3af3600f045d60d9c1dc1fb4d6 implemented that request. You need to check and possibly define those font names as well.

targzeta commented 4 years ago

Hi @gijsbers, yes, with these settings the buttons are rendered again with the correct fonts.

I haven't told you that my prefoverride also sets:

ActiveWorkspaceFontNameXft    = ""
NormalWorkspaceFontNameXft    = ""

and the doc says:

# Name of the active workspace button font (fallback: ActiveButtonFontName)
# NormalWorkspaceFontNameXft="sans-serif:size=12

so, I think that it doesn't do the fallback.

Thank you again, Emanuele

gijsbers commented 4 years ago

You should check if your settings take effect by: icewm --postpreferences | grep -e ButtonFont -e WorkspaceFont. If you could read commit 80c5b4af3f9d4e3af3600f045d60d9c1dc1fb4d6 then you should see that it first attempts the workspace font and if that fails does it attempt the button font. I tested this and it worked. Maybe you only set the Xft font names, but not the plain font names (without Xft suffix.)

targzeta commented 4 years ago

Yes, I have olny the NormalWorkspaceFontNameXft and not the NormalWorkspaceFontName in my prefoverride. It's a little intricate, but it's clear!

Thank you for your works! Emanuele