search

bbidulock / icewm

A window manager designed for speed, usability, and consistency
Other
586 stars 99 forks source link

unicode characters in a latin1 locale #519

Closed gprints closed 1 year ago

gprints commented 3 years ago

I'm running a de_DE.ISO8859-1 locale and icewm 1.9.2 is ignoring that and outputting unicode character sequences, e.g. in the Preferences Menu, it says "Aâ| - Lâ|" instead of "A... - L..." and a quick look into the source code reveals only a check of the font contains unicode characters, but no check for the locale. Do we really need unicode instead of just using three ASCII dots?

Code7R commented 3 years ago

Unicode ellipsis takes less space and also looks better, IMHO. Anyway, that situation can be solved by throwing an additional nl_langinfo check on it.

gijsbers commented 1 year ago

The de_DE.ISO8859-1 locale looks fine to me. Is this still a concern?

gprints commented 1 year ago

While the incorrect display got fiexed, I still wonder if a single unicode character is worth having a dependency to another library.

gijsbers commented 1 year ago

Maybe not? How can I check this? Which library?

gprints commented 1 year ago

Sorry, I was wrong. libiconv isn't being used for "...", it's hardcoded as

define utf8ellipsis "\xe2\x80\xa6"

const unsigned utf32ellipsis = 0x2026;

But as far as the original bug is concearned, it got fixed.