improved grouped tab drawing routine

[exebook]

Old one has issues with alignment/positioning, text did not fit with 10+ windows under one tab, black non configurable color looked out of theme.

what I did:

• TaskBarGroupingStyle (0, 1) - 0-default dots, 1-digits
• polished positioning of the digital counter to align perfectly with the icon and the text
• used clrActiveTitleBar(Text) for the digital counter
• used bg.brighter() for the dots
• carefully positioned dots at the bottom of the tab and behind text (if text overlaps for those who use really thin task bar)
• in case brighter() yields the same color as bg (this happens if bg was white) then darker() is used instead.

rationale for having dots by default is that users who would love digits are more likely to be friends with preferences.

[gijsbers]

Then we would have two preferences for grouping. I prefer merging this option in TaskBarTaskGrouping, with 0 for off, 1 for numbers, 2 for dots and 3 for both. Also, font->height() gives you ascent+descent.

[exebook]

Having a single setting with 1/2/3 is obviously very convenient.

[gijsbers]

You can refrain from updating icewm.adoc, since that trickles down from the ice-wm website, but please update icewm-preferences.pod.

[danfe]

I'm glad that the problem with grouping indication is acknowledged and solution is being developed. I won't comment on the actual code, just share some of my thoughts on the looks.

• Currently, the indicator (black circle with window count) overlaps with the icon and/or window title, which does not look nice (recognized and mentioned above);
• Circle itself only looks good for single-digit numbers, after 10 it should be stretched (it generally helps to always think about hundreds and thousands when designing this type of things) -- also recognized and mentioned above;
• I've played a bit with the indicator shape (stretched circle, oval, etc.), and rectangle appears like the best, especially if I round the edges at about 2 pixels (see attached images below); it should also be easier to implement;
• I've also played with its position, and concluded that it looks fine when the counter is either placed on the right (in the example below, it's black, on the bottom) or between the icon and the title (blue, on the top). Placing it in front of the icon is confusing as the counter looks like the icon itself.

[gijsbers]

Can you post the relevant code how to draw the first example?

[danfe]

Well, I could, but I'd have to write it first. So far I've simply used my 1337 Photoshop Gimp/AzPainter skillz for those mockups. ;-)

[gijsbers]

Patch is applied, with modifications. Attempted to get rounded rectangles by drawing thick rounded lines. Thanks for all your contributions.

[danfe]

Attempted to get rounded rectangles by drawing thick rounded lines.

Thanks. While it's still far from perfect (especially with dark or blueish themes, as demonstrated below, the text is barely visible against the background), this sets a nice foundation for further improvements.

Perhaps the text color should match the background of the taskbar, and "rectangle" color match the text (that is, use the same colors but inversed)?

This is with blueHeart theme:

This is with CrystalBlue theme:

Dotted mode looks fine already.