search

bbidulock / icewm

A window manager designed for speed, usability, and consistency
Other
577 stars 98 forks source link

systray background glitch #626

Closed zaza42 closed 2 years ago

zaza42 commented 2 years ago

The background of system tray icons go glitched sometimes after icewm -r, like: icewm-29-toolbar-colorbug3 icewm-29-toolbar-colorbug2 icewm-29-toolbar-colorbug

The top and bottom of the background fade are reversed. I can't reproduce it, but it occured a many times. A repeated icewm -r usually solves this problems. I encounter this from version 2.9.0 only.

gijsbers commented 2 years ago

Is this still your mix of jim-mac and ElbergGreen? I have seen such a glitch before, but fail to reproduce it since 2.9.2. Check this hypothesis: "To reproduce, the theme must have a taskbar/taskbarbg.xpm, which isn't part of Gradients." Then the fillPixmap function will be used, which looks buggy to me. I partially fixed it a bit in commit 7db6efc83d94cba8811b8c11ae8b84f6069ab6a5.

zaza42 commented 2 years ago

Ohh, it was before 2.9.2 - I've just realized this new release now. I'll keep an eye on it from now on to see if it improves.

(Don't sit back, I'll show you other small bugs soon. ;-> )

gijsbers commented 2 years ago

This must be it. I couldn't reproduce it initially, because I had Alpha=1. The glitch was probably due to commit 96d6feec365e55c78e3b815dd32fc2f4792b4ee4, which includes an optimization to reduce the number of taskbar relayouts on startup.

zaza42 commented 2 years ago

IceWM 2.9.2 now ;-< icewm-29-toolbar-292-colorbug4

gijsbers commented 2 years ago

Looks better, right?

zaza42 commented 2 years ago

Still flipped gradient on pasystray and audacious icons. :-<

gijsbers commented 2 years ago

More rigorous fix. Try again.

zaza42 commented 2 years ago

The latest git version seems to have fixed this bug. Thanx!

gijsbers commented 2 years ago

Thanks for letting us know!