search

bbidulock / icewm

A window manager designed for speed, usability, and consistency
Other
577 stars 98 forks source link

[Enhancement] Allow TaskBarGraphHeight= to be defined in theme file #659

Closed cheapy closed 2 years ago

cheapy commented 2 years ago

Currently, in order to support themes to fit different monitor resolutions and sizes, I need to put an entry into prefoverride or change the main preferences value which would affect all themes on all screen types. Otherwise the taskbar/toolbar icon and monitor heights might not be reasonable for the screen.

Following what seems to be a normal convention, I've created theme variants to fit general ranges of screen sizes, and it would make be better if the theme itself could provide a value that overrides the default value in preferences, and which the user could optionally override themselves in prefoverride if needed.

gijsbers commented 2 years ago

Did this help you?

cheapy commented 2 years ago

Thanks much! Sorry, I didn't notice a notification before. I will give it a try tomorrow night.

cheapy commented 2 years ago

Yes, it worked perfectly, tested as follows: Default from preferences override possible by theme override over theme value by prefoverride

cheapy commented 2 years ago

Thanks again!

gijsbers commented 2 years ago

Is this sufficient, or do you need/prefer a release?

cheapy commented 2 years ago

If you could just include it in the next release, please, that would be great. When I see it's working I'll add it to the themes.

Thanks again :)

gijsbers commented 2 years ago

It's in the new 2.9.8 release.