search

bbidulock / icewm

A window manager designed for speed, usability, and consistency
Other
587 stars 99 forks source link

Minor Issue with tray icon bg #68

Closed SolisX closed 6 years ago

SolisX commented 8 years ago

Hello bbidulock,

It would be nice if the icons the are not handled by icewm tray like nmapplet would match the taskbarbg.xpm. It's an eye sore to have the taskbarbg not match.

http://s8.postimg.org/6zsr86hpw/icewm.jpg

Also this might be asking to much but it would a if the icewm menu could be made to look like the whisker menu.

bbidulock commented 8 years ago

Please check to see if commit 2686986 fixes the tray icon background issue.

SolisX commented 8 years ago

Hello bbiulock,

No it does not fix tray icons not matching the taskbarbg.xpm.

SolisX commented 8 years ago

Hello Bbiulock,

http://s33.postimg.org/pksmn8zqn/screen06.png

Although this is not exactly the same issue it's similar. The apps that you tray with icewm when using the flat look don't match. The same is true with taskbutton-active, taskbutton-minimized. Although you can set them as gradients in the default.theme it does look correct. I think i would be better to have a separate trayiconbg.xpm, trayiconactive.xpm, trayiconminimized.xpm taskbuttonbegin.xpm, taskbuttonend.xpm, clockbegin.xpm and clockend.xpm.

gijsbers commented 7 years ago

@SolisX is this still an issue or has this been resolved by commit 374d553147999fa2a6298bf8507f50a27135330e which added the TrayIconMaxWidth and TrayIconMaxHeight options?

bbidulock commented 6 years ago

I think this is fixed. Now windows are transparent all the way down to the taskbar. Task bar pixmaps and gradients show under the icons. See attached with cbaticon and pasystray.

tray

bbidulock commented 6 years ago

Please give it a shot and see if we are done with this one.

SolisX commented 6 years ago

Sorry for the late reply. I will try the newest version of icewm to see if its fixed.

SolisX commented 6 years ago

Yes this issue is fixed in icewm 1.4.2.583.

SolisX commented 6 years ago

HelloEveryone,

With the flat look themes it's drawing the black border around the tray icons.

See the screenshot. https://s1.postimg.org/60b8iwa09b/screen01.png

bbidulock commented 6 years ago

You know that you can upload the file rather than positing it somewhere, right? Like this: screen01

bbidulock commented 6 years ago

Works for me with flat look themes. When running the new icewm to test you must also make sure that you are running the new icewmtray.

SolisX commented 6 years ago

Hello Bbidulock,

You need to start icewm with Dark-Ice theme then switch to a flat look theme. It will keep the borders from the other theme. Also notice that if i start icewm with flat look when switch to a pixmap look it will not draw the border. So icewm is keeping what ever style you started it with for the tray icons when switching themes.

Also about uploading files. I tried to drag and drop the screenshot to cilpboard but it keeps saying there is a problem with the upload.

SolisX commented 6 years ago

Wicd tray icon corrupts when using the flat look. screen02

Also i have conky running and when icewm starts up now the taskbutton for conky show up which does not happen on the previous version of icewm.

bbidulock commented 6 years ago

I don't have a Dark-Ice theme.

SolisX commented 6 years ago

Here is the Dark-Ice theme. Dark-Ice.zip

bbidulock commented 6 years ago

I just ran through every theme that come with icewm as well as those in icewm-extra-themes one after the other and they all render correctly.

bbidulock commented 6 years ago

Different problem. When one starts with Dark-Ice (the only theme that has TrayDrawBevel=1), the geometry of the tray is being calculated to exclude the bevel. When the theme changes (to one with TrayDrawBevel=0), the geometries are not being recalculated so there is a gap where the bevel would be.

SolisX commented 6 years ago

Oh glad you figured out what is causing the issue. So i will make a new issue and close this one.