bbidulock / icewm

A window manager designed for speed, usability, and consistency
Other
570 stars 97 forks source link

Icewm sometimes crashes when a window doesn't respond to close request #729

Closed plomari closed 10 months ago

plomari commented 1 year ago

When a windows doesn't respond to being closed (like clicking on the X in the window decorations), icewm shows a message and offers you to kill it. I think this is a relatively recently added feature.

The problem is that sometimes, when the application doesn't respond and other circumstances I do not know, icewm crashes. (I was pleased to see that icewm is just restarted and even keeps the window locations, although they were shifted by the window decoration's size.) I get applications not responding relatively often. They're only temporarily frozen, but long enough to trigger Icewm's timeout. It doesn't always crash. Maybe it has to do with the application terminating while icewm still displays the message. Hard to reproduce.

I don't know if this is fixed in newer icewm releases.

gijsbers commented 1 year ago

Check if the client has a non-zero WM_CLASS property.

gijsbers commented 1 year ago

Before the crash, you do or don't see a popup with the messages Client with PID fails to respond. Do you wish to terminate this client?.

plomari commented 1 year ago

In at least one case the WM_CLASS property was set. It was a Qt application. I can check for the exact message next time it happens.

plomari commented 1 year ago

Before the crash, you do or don't see a popup with the messages Client with PID fails to respond. Do you wish to terminate this client?.

Yes, this exact message. I'm still using an older icewm release (3.3.3), but lately this situation didn't happen. It only happened once just now, but icewm didn't crash.

gijsbers commented 1 year ago

Maybe increasing the value for # PingTimeout=3 # [0-86400] avoids this problem.

plomari commented 9 months ago

I get the dialog occasionally, but it never crashed again.

gijsbers commented 9 months ago

That confirms the fix. Thanks.