search

bbidulock / icewm

A window manager designed for speed, usability, and consistency
Other
589 stars 100 forks source link

lower focus on lowered windows #776

Closed irush-cs closed 4 months ago

irush-cs commented 4 months ago

After pressing alt+f3 to fully lower a window, the focus window list still keeps that window second, so alt+tab returns to the lowered window. This patch moved the lowered window to the bottom of the focus list (which is the behavior in my older icewm 1.3....).

gijsbers commented 4 months ago

This doesn't take into account transients. It would be better to use doLower instead, but there is another problem. wmLower is called from several places. Only when it is called from an action (actionLower) should it call lowerFocusFrame. I'll take this PR as a hint. Thanks.

gijsbers commented 4 months ago

See commit f343387.

Could you perhaps evaluate the translation of icewm into Hebrew? I'm interested also in how well icewm supports right-to-left languages.

irush-cs commented 4 months ago

Thanks, the patch in the commit works for me :)

Regarding right-to-left, I usually use English as the main language so I don't encounter everything. But giving it a quick look, some layouts are still reversed. E.g. in the main menu - the icons should be on the right, left to them should be the text (aligned to the right), and the triangle for the submenu should be on the left. On the window menus similar issue - the text should be on the right and the keyboard shortcuts on the left, and if there's a submenu - it should also open to the left. Some translations are also missing or inaccurate, but I'm not sure what they should be... (again, usually not using Hebrew interface)