Open Lost-Projects opened 6 years ago
Hmm, not sure and not around a machine I can test on for over a week (visiting family abroad).
I've only run the makefile on Ubuntu with Java previously installed - I think this JAD
stuff only comes into play if Java is not already present (but I may be wrong)...
Are you getting errors that are fixed after updating the link?
So I was mistaken about those JAD downloads - seems it is a decompiler and not a java installer as I assumed. Seems like they should be updated - thanks @Lost-Projects .
I'll remind myself here to update them next time I get my webOS Meta-Doctor machine up and running:
https://github.com/bbito/meta-doctor/blob/fec59e1e1dcdefa5512eb04d8628c5192fb02aa9/Makefile#L1265
curl -L -o $@ https://varaneckas.com/jad/jad158g.mac.intel.zip
https://github.com/bbito/meta-doctor/blob/fec59e1e1dcdefa5512eb04d8628c5192fb02aa9/Makefile#L1274
curl -L -o $@ https://varaneckas.com/jad/jad158e.linux.static.zip
https://github.com/bbito/meta-doctor/blob/fec59e1e1dcdefa5512eb04d8628c5192fb02aa9/Makefile#L1278
curl -L -o $@ https://sourceforge.net/projects/jode/files/jode/1.1.2-pre1/jode-1.1.2-pre1.jar/download
The sourceforge URL is the same, but https...
@Lost-Projects I pushed a new fork: "url-update" if you want to give it a try. Personally I have tested the URLs with wget and curl, but I don't know how to trigger the downloads or use of the tools in the meta-doctor. https://github.com/bbito/meta-doctor/tree/url-update
@Lost-Projects as far as I can tell, variable that kicks JODE/JAD into action is PATCH_DOCTOR
and this hasn't been used since this May 15, 2011 commit: https://github.com/webos-internals/meta-doctor/commit/4abbf71291193b9ad9b60bbb489eca1b455e8abc#diff-b67911656ef5d18c4ae36cb6741b7965
from @whitby
So while correcting the links probably has no ill effects, I don't think they'll ever be called from the meta-doctor makefile or any of the scripts currently in the repo.
My understanding of how all this works is limited, but as far as I can tell there are no current scripts or Makefile flags that will make the existing ifeq (${PATCH_DOCTOR},1)
checks return true.
These checks currently appear at the following Makefile locations:
https://github.com/bbito/meta-doctor/blob/fec59e1e1dcdefa5512eb04d8628c5192fb02aa9/Makefile#L348
https://github.com/bbito/meta-doctor/blob/fec59e1e1dcdefa5512eb04d8628c5192fb02aa9/Makefile#L380
https://github.com/bbito/meta-doctor/blob/fec59e1e1dcdefa5512eb04d8628c5192fb02aa9/Makefile#L386
https://github.com/bbito/meta-doctor/blob/fec59e1e1dcdefa5512eb04d8628c5192fb02aa9/Makefile#L874
https://github.com/bbito/meta-doctor/blob/fec59e1e1dcdefa5512eb04d8628c5192fb02aa9/Makefile#L912
Near the end of the make file. Is this correct? https://varaneckas.com/jad/jad158e.linux.static.zip
If correct, a similar modification would be required for jad158g.mac.intel.zip
Maybe this should go upstream too?