Update warg - Githubissues

bbkane / shovel

Explore complex DNS records by making and aggregating DNS requests

MIT License

6 stars 0 forks source link

Update warg #35

Closed bbkane closed 8 months ago

bbkane commented 9 months ago

including:

breaking changes
tests with the new context
updating the serve command

bbkane commented 9 months ago

Updated the CLI so it now runs with the new warg, but realized warg.GoldenTest doesn't let you pass a context in.

So I made https://github.com/bbkane/warg/tree/bbkane/update-for-shovel to fix that. I don't want to cut a new version of warg until I know shovel works, so the plan going forward is to use go.work to get it working locally, then update warg and shovel and release both of them.

bbkane commented 9 months ago

Note that the current commit fails golangci-lint , but I'm out of time to fix this morning.

bbkane commented 8 months ago

Current TODOs:

finish porting tests from Test_parseCmdCtx to TestParseSubnet and TestParseNameserver
rm Test_parseCmdCtx (note that the relevant parsing is still goldentested)
re-add lefthook
add docs to ParseNameservers
get otel going from cmdCtx instead of flags...
push warg update and stop go work stuff

bbkane commented 8 months ago

Current TODOs

add docs to ParseNameservers
test otel flag name changes and update shovel_ansible
push warg update and stop go work stuff