Closed Sanae6 closed 2 months ago
Hi @Sanae6,
Thank you for this excellent PR!
Before starting the review, I'd like you to remove LinkedBinary
.
Indeed, binary values should be treated like raw JSON strings and always be copied; this is part of a larger (incomplete) refactoring to reduce the size of VariantContent
.
Then, of course, simplify the names accordingly, since we no longer need the distinction between "owned" and "linked" binary values.
Best regards, Benoit
I removed LinkedBinaryValue and renamed OwnedBinaryValue to BinaryValue. Not sure what to name Binary, but I left it as something sensible enough.
Alright! Force pushed, seems nothing is broken :+1:
It seems that you lost your version of string_length_size_4.cpp
while merging the conflict.
Made the changes you wanted, testing MsgPackBinary comparison actually revealed my initial implementation didn't work, so I fixed that as well.
I added the three missing tests, squashed, and merged.
Thank you again for this excellent contribution ❤️
This feature is available in ArduinoJson 7.1.0
I've added binary support to the msgpack deserializer and serializer, along with a fallback for the json serializer. I've also added some tests to the relevant files. Let me know if there's anything I can do to make this implementation better. Thank you for the amazing library :)
This would fix and close #922.