search

bblanchon / pdfium-binaries

📰 Binary distribution of PDFium
908 stars 195 forks source link

Unreal Engine Plugin #110

Closed ffreality closed 1 year ago

ffreality commented 1 year ago

I saw that you have a "Related Projects" section on this repository. I created an Unreal Engine plugin based on your binaries. Is there any code of conduct like requirements to share my project on that section ? My repo.

https://github.com/FF-Projects-UE/PDF_Reader

mara004 commented 1 year ago

I strongly vote against referencing this project as it does not fulfill minimum code/development quality expectations yet.[^a] Take a look at recent conversation on pdfium's mailing list for background.

[^a]: though pdfium-binaries does not have official requirements AFAIK

ffreality commented 1 year ago

(TL;DR like you) you just speak gibberish. Because you speak about first version of my plugin.

Why I said you spoke gibberish ? 1- It is your choice to referencing or not but...

2- It is the strongest Unreal Engine PDF plugin right now and you can't say Unreal Engine is a dispensable development environment. (It does even line break, auto text wrapping like high level supports)

3- PDFium doesn't have any documentation or answer for most times. (They even said they were not good at C++ and doesn't support 3rd party integrations. They said this on bugs page.)

4- Your only anchor about my "bad code quality" was about your obsession with char allocation size. Until my question, they tought first usage of FPDF_GetText() would give them necessary buffer lenghts like other functions. But they got error and they had to do manual allocation. And even, they accepted "2 bytes per char" after sending couple e-mails to each other. I am sure that they would use "4 bytes per char" before my specific question. Using "4" was not really bad because even Giesele thought we should use 4 because double chars. But Google developers corrected it with pdfium's behavior. You and them should "thank" me about my question to pointing it out. And you also forgot to add NULL pointer. Using 4 wouldn't cause a crash.

5- I used second for loop and Giesele wasn't happy about it because I didn't know that I could use buffers as WIDECHAR. Also I said that "I knew second for loop was unnecessary and bad but I didn't find any documentation about it". After that, Google developers came and they offered better solution (WIDECHAR usage). So, I fixed every text based implementations. Before them, I didn't try to find better workflows. Because, that function's performance wouldn't be a problem for Unreal's aspect and I had to solve more important problems about plugin.

6- And also you... You didn't review my whole code, help me about real problems like external web font and image inserting or android crash at latest versions of pdfium or bitmap rendering buffer lenghts. You just say "I AM AGAINST IT BECAUSE HE BROKE MY FEELINGS ABOUT ALLOCATION SIZE".

I am sure you didn't even look at its current state and you didn't even do anything beyond pointing some emails (right now and at our conversation before).
Your first issue about second loop already be fixed before you posted it. You didn't even checked it before posting.

7- Give me "minimum code quality expectation" , test method, documentation or a review. So, I can improve it, if there will any problem. (Just don't forget that this is blueprint supported Unreal Engine runtime plugin. Not an improvement about pdfium. So, we can't do everything with your "trues". For example, releasing or closing times of stuffs should be correct for "runtime" usage.) Without a proper test result or a review from a developer who knows both Unreal and C++, you can't say my current code quality is bad.

8- I want to look at any C/C++ based contributions of the person who doesn't like my coding. I mean you.

I am really okay to not get any reference on this repo. I am just NOT okay with "your" judgement. I was even okay with you but you came here with some "against".

Current state and problems:

mara004 commented 1 year ago

Mailing list threads for reference: https://groups.google.com/g/pdfium/c/HwqzzGWWXVU/m/Kzzbm6rHAgAJ https://groups.google.com/g/pdfium/c/tOLQcjjKS_A

ffreality commented 1 year ago

https://groups.google.com/g/pdfium/c/HwqzzGWWXVU/m/Kzzbm6rHAgAJ https://groups.google.com/g/pdfium/c/tOLQcjjKS_A

Image Insert: 1- I already said about image inserting is problematic So, I deleted that function and solved it with LibHaru's help. 2- You point "my emails" which about "my problems" and currently there are no given solutions or documentations for that problem.

Extracting Text Block: 1- As I say before, I already fixed that. You judge me with my old code and there is no sign about that problem. 2- As I say before on my long comment and mails at below, They don't even be sure at first place about how should they allocate buffers and they thought FPDF_GetText() would give buffer lenght. When they found out they had to use manual allocation, "they" suggest 4 at first and they decided to convert it 2, after some discussions.

https://groups.google.com/g/pdfium/c/HwqzzGWWXVU/m/Rp1E2kH8AgAJ https://groups.google.com/g/pdfium/c/HwqzzGWWXVU/m/s9jPr0n7AgAJ

and both of us agreed to use 2.

So, will you give me a "real" problematic section about my "current" code, or do you want to continue speak gibberish about my old code and use my emails as referance ?

mara004 commented 1 year ago

Uh, what a waste of time. Theoretically there would be a lot to say on your comments, but there's not much point.

Mostly what you're writing is groundless. The only matter where I see error on my part was the confusion around the exact amount of excessive allocation, that was a double blunder out of tiredness and I already apologized twice. You're also right I forgot to explicitly mention the NUL terminator once, which was because I only thought about the allocation per char in that context, not the total amount, which I agree was confusing again. (FWIW, pypdfium2's code did it right, also historically.)

But otherwise, you are being highly impolite, insultive and display a behaviour that is not tolerable.

ffreality commented 1 year ago

Uh, what a waste of time. Theoretically there would be a lot to say on your comments, but there's not much point.

Mostly what you're writing is groundless. The only matter where I see some error on my part was the confusion around the exact amount of excessive allocation, that was a blunder out of tiredness and I already apologized twice. You're also right I forgot to explicitly mention the NUL terminator once, which was because I only thought about the allocation per char in that context, not about the total amount.

Otherwise, you are being highly impolite and are displaying a behaviour that is not tolerable.

You are not at the point to judge me about my politeness and in fact your argument is groundless.

So, can you really judge me ?

If team don't want to give a referance, that's okay. But judging with an argument of bad code is hilarious because you are not C++ developer and speak about old things.

mara004 commented 1 year ago

I'm wondering if it would be time to file a report to GH support...

ffreality commented 1 year ago

I'm wondering if it would be time to file a report to GH support...

https://youtube.com/shorts/nuiaoaH1zmA?feature=share

mara004 commented 1 year ago

I'm not looking at the video, for fear it might be something violent or else gravely harassing. But I reported and blocked you now.

ffreality commented 1 year ago

It was breaking bad's "GUS - DOT IT" scene. :D I don't think Youtube or a TV show would allow a "gravely harrasing" scene.

mara004 commented 1 year ago

OK, if it really was just a TV show scene. But things are getting a bit too risky for me here, and you never know.

ffreality commented 1 year ago

I filed a report about you, too.

Because you gave misleading informations based on my old and solved code which didn't have any previously shared information about correct usage. And I say before, team had to discuss about correct usage.

Also, you didn't have any current bad implementations samples which were not necessary for Unreal Engine. You didn't give me test method or review it. You judged me directly with my old code. If there are "current" problems, of course I will solve them or at least try it.

So, "you" can cause harm to me with your words.

//

You wrote "I am strongly against ..." couple minutes after I open this issue. Did you have any time to really check is there any problem about my code ? If you or any one give me a "real and current" bad implementation sample about my code, I won't be sad about not getting any referance.

You brought your personal feelings to here.