search

bblanchon / pdfium-binaries

📰 Binary distribution of PDFium
789 stars 166 forks source link

Fix musl build #130

Closed jerbob92 closed 7 months ago

jerbob92 commented 7 months ago

Fixes #129

This change will produce a musl build that does not have any gcc/glibc symbol imports. The resulting .so file is quite big (15MB), and I'm not 100% if this is what we're supposed to do.

I have removed the -D_LIBCPP_HAS_MUSL_LIBC, because that only has effect when use_custom_libcxx is true.

jerbob92 commented 7 months ago

I have just compiled a build with this and used it in a pure Alpine docker container together with a musl build of pdfium-cli, and it works!

bblanchon commented 7 months ago

Awesome work. Thanks!

jerbob92 commented 7 months ago

@bblanchon would it be possible to trigger the release manually just this once so that a valid musl build is available?

bblanchon commented 7 months ago

Is it OK if I replace the asset in the latest release?

jerbob92 commented 7 months ago

Is it OK if I replace the asset in the latest release?

Yeah that would also work!

bblanchon commented 7 months ago

I manually updated pdfium-linux-musl-x64.tgz and pdfium-linux-musl-x86.tgz, but I didn't touch the V8 builds.