Make Emscripten SDK (emsdk) version a workflow input

bblanchon / pdfium-binaries

📰 Binary distribution of PDFium

904 stars 194 forks source link

Make Emscripten SDK (emsdk) version a workflow input #143

Closed sungaila closed 1 year ago

sungaila commented 1 year ago

Right now the wasm build step script is hard coded to use emsdk 3.1.34. This PR adds a workflow input to define the desired emsdk version for the Build one workflow (still defaults to 3.1.34).

This is just a personal convenience for my fork where I can create and test pdfium wasm builds with different emsdk versions. But it isn't of much importance otherwise.

The commits are test-related and should be squashed into a single nice commit before merging.

bblanchon commented 1 year ago

Hi @sungaila,

Thank you for this PR. I squashed the commits and made the environment variable uppercase. Hopefully, I didn't break anything.

Best regards, Benoit