NuGet: Add release notes to packages

bblanchon / pdfium-binaries

📰 Binary distribution of PDFium

904 stars 194 forks source link

NuGet: Add release notes to packages #154

Closed sungaila closed 10 months ago

sungaila commented 10 months ago

The GitHub releases have these nice auto-generated release notes containing the chromium branch name and commit messages. It would be great to have these for the NuGet packages, too.

NuGet release notes are plain text and don't support markdown (https://github.com/NuGet/NuGetGallery/issues/8889) so the format and URLs had to be stripped.

I haven't tested this change myself so it would be a good idea to double check if this bash script/workflow yaml looks correct.

bblanchon commented 10 months ago

I don't think we'll manage to pass a multiline string to the command line. We should patch the nuspec file instead.

bblanchon commented 10 months ago

On nuget.org, I could find very few packages that define the release notes, and the ones I found only included a link to an external page. I suggest we do the same with a link to the GitHub release.

sungaila commented 10 months ago

I suggest we do the same with a link to the GitHub release.

Then how about doing just that. :-) This one has no fallback if the chromium branch was unset. Maybe something like https://github.com/bblanchon/pdfium-binaries/releases/latest?

bblanchon commented 10 months ago

sungaila commented 10 months ago

@jerbob92 Lookin' great! 😊