search

bblanchon / pdfium-binaries

📰 Binary distribution of PDFium
908 stars 195 forks source link

iOS V8 builds are broken: no release this week 😞 #99

Closed bblanchon closed 1 year ago

bblanchon commented 1 year ago

Today's build failed because of a link error caused by the following change:

https://chromium-review.googlesource.com/c/v8/v8/+/4225996

The V8 team reverted the commit, but the PDFium source still points to a faulty version of V8.

bblanchon commented 1 year ago

The PDFium team didn't update its V8 version yet, so the build is still failing. They usually update the V8 dependency every 10 to 30 days, so we might get a build next week 🤞

mara004 commented 1 year ago

Would it be possible to just release the builds that worked and skip those that failed? i. e. including V8 builds on an "if it works" basis?

bblanchon commented 1 year ago

I'm afraid it could break some builds:

Shouldn't the release workflow stop if building for one platform fails? The scheduled workflow of pypdfium2 currently assumes that all required binaries are present. If this isn't the case, I fear that the repository would be left in a half-broken state, or that some released packages would be invalid.

Source: https://github.com/bblanchon/pdfium-binaries/issues/88#issue-1326023341

It's the first time that the V8 build prevents the non-V8 build from being released; let's see if it happens again before taking radical measures.

Besides, there is probably no significant change in PDFium. If so, you can still download the build artifacts.

mara004 commented 1 year ago

Oh yeah, I remember ;) [^1] The situation might be a bit different for v8 vs non-v8, but I agree this isn't relevant if it doesn't happen too often.

[^1]: Though I think pypdfium2's setup code has become more robust. It should now correctly handle missing binaries and abort on its own.