search

bblfsh / cpp-driver

C++ AST extractor / driver for the bblfsh project
GNU General Public License v3.0
11 stars 12 forks source link

Update SDK, fix now-not-silently-dropped fields #26

Closed juanjux closed 5 years ago

juanjux commented 5 years ago

Same as the Python and Ruby PRs.

juanjux commented 5 years ago

@dennwc changed the many Any'es to use Drop+Any, PTAL.

creachadair commented 5 years ago

Having hard times orienting myself in the tradoffs involved in choosing this approach over e.g adding Map(Part("_", Obj("field": Any(),)) in Preprocessor.

I wish we could have a meeting on this with @creachadair, or something and agree on way of mapping things 😕

I'm happy to schedule a meeting if you all would like to talk about it. I have no obviously-correct answer here, but would be glad to talk it out.

I don't think we need to block this PR for it, since it's a larger design question that we probably shouldn't address until we know what the goal is. :)