Add Operator Role - Githubissues

bblfsh / cpp-driver

C++ AST extractor / driver for the bblfsh project

GNU General Public License v3.0

11 stars 12 forks source link

Add Operator Role #62

Closed BFergerson closed 5 years ago

BFergerson commented 5 years ago

same as #59 with DCO fix

This change is

bzz commented 5 years ago

CI seems to be failing integration tests

+ docker exec ci-build:latest bblfshctl driver install cpp docker-daemon:ci-build:latest
v1 test "/home/travis/gopath/src/github.com/bblfsh/cpp-driver/fixtures/_integration.cpp" failed
exit status 1
The command "go run test.go --bblfshd $BBLFSHD_VERSION ci-build" exited with 1.

chess-equality commented 5 years ago

Hi all (@bzz , @kuba-- ), I'm working with @BFergerson on this one.

I'm getting no such image when running go run ./test.go above, would you have any suggestions where I could start looking to solve this?

Thanks.

kuba-- commented 5 years ago

@chess-equality, could you try to do it in multiple steps:

# compile builder
go build -o cpp-build build.go 
# build image cpp-driver
./cpp-build cpp-driver

# compile tester
go build -o cpp-test test.go
# test against cpp-driver image
./cpp-test cpp-driver

chess-equality commented 5 years ago

@kuba-- Still returning no such image.

I also noticed it is creating extra images with no tags.

I am using Go 1.13.

kuba-- commented 5 years ago

@chess-equality - looks it can't find the latest image of bblfshd. I suggest to pull it first:

docker pull bblfsh/bblfshd:latest

and then run:

./cpp-test cpp-driver

chess-equality commented 5 years ago

@kuba-- Thanks, it is working now.

BFergerson commented 5 years ago

@kuba--, tests are passing now. Please take another look at this when you get a chance.

Out of curiosity, if/once accepted, do you know when a release will be published? I've also contributed code for bblfsh/php-driver and bblfsh/ruby-driver but those haven't published any new releases since I've contributed. I'm curious when this fix will be included in a release and if there is anything I can do to expedite releases on the other drivers. Thanks.

kuba-- commented 5 years ago

@BFergerson - right now we have MAINTAINERS file for each repo. So, you should ping repo's maintainers (I don't think, there is any issue to release a new driver, if it's backward compatible). For C++, I'll ask @ncordon and @dennwc (just in case), because IMO would be good to also merge and release https://github.com/bblfsh/cpp-driver/pull/61