bblfsh / documentation

Babelfish documentation (GitBook)

https://docs.sourced.tech/babelfish

Creative Commons Attribution Share Alike 4.0 International

41 stars 30 forks source link

Add a UAST decoding spec #251

Closed dennwc closed 5 years ago

dennwc commented 5 years ago

Add a UAST decoding spec written based on the design doc and Go implementation.

Signed-off-by: Denys Smirnov denys@sourced.tech

This change is

dennwc commented 5 years ago

@creachadair Thank you for all the valuable comments, everything is addressed, rebased and the PR is ready for another round.

Note that https://github.com/bblfsh/documentation/issues/255 still needs to be resolved, but let's make it a separate PR.

CI may fail, but should be fixed by https://github.com/bblfsh/documentation/pull/254.

dennwc commented 5 years ago

This is getting quite long and there are still topics to discuss, so I'm splitting a trivial part into #260. Will rebase this one, once it's merged.

bzz commented 5 years ago

Great job!

260 seems to be merged now.

And I wonder, what would be the best place to move the https://github.com/bblfsh/documentation/pull/251#discussion_r290876554 discussion - I feel that this is pretty important feedback and it would be sad to just drop that accidentally.

bzz commented 5 years ago

FIXME(dennwc): explain the v2 protocol, list relevant proto files and UAST decoding spec

@bzz @creachadair Do you think it makes sense to do it as a separate PR?

@dennwc Both ways make sense to me, whichever you prefer.

(somehow this discussion does not show up in reviewable for me, sorry)