Closed bzz closed 5 years ago
CI failure is un-related
- /site/using-babelfish/getting-started.html
* External link https://www.docker.com/community-edition failed: 403 No error
@dennwc thank you for the prompt review - all feedback has been addressed, it's ready for another round + would appreciate some feedback on a couple of open questions/improvement suggestions above.
Thank you for the reviews - all feedback addressed, @dennwc it's ready for another round.
Github (again) does an awesome job of randomly hiding all comments including unresolved ones.
The change looks good, except for the driver filter (ForCurrentSDK
and friends).
Somehow these must have slipped my mind, I'm sorry about that:
Will addd asap.
All feedback has been addressed, here is an example of the output:
Script uses go modules now, in order to be runnable without GOPATH and avoid confusion with SDK versions.
As counting of the code usage is not implemented yet, /0
is not reported by default any more - let me know what you think!
Also it includes only 10 drivers that are actively maintained by us.
Initial version of the report that only includes UAST types, found in all driver's fixtures. Triggered by
make types
.Algorithm:
/fixtures/*.sem.uast
and count alluast:*
TODOs
normalizer.go
and count all usages ofuast.*
uast.*
with go AST from SDK dynamicallyExample report:
This change is