search

bblfsh / documentation

Babelfish documentation (GitBook)
https://docs.sourced.tech/babelfish
Creative Commons Attribution Share Alike 4.0 International
41 stars 30 forks source link

Info about Supported languages v2 #274

Closed kuba-- closed 5 years ago

kuba-- commented 5 years ago

Signed-off-by: kuba-- kuba@sourced.tech Related to: https://github.com/bblfsh/documentation/issues/255

This PR adds a short info about a new SupportedLanguages v2 requests.

This change is Reviewable

ncordon commented 5 years ago

using-babelfish/grpc-usage-example.md, line 146 at r2 (raw file):

Previously, creachadair (M. J. Fromberger) wrote…
It probably _does_ make sense to link to the data type in godoc.org (though are we still using gopkg.in for that package?). But I also agree that it's helpful to have an example: When I'm coding against an interface, the schema type is often not sufficient to really illustrate what I'm expecting, so examples are helpful. I don't feel strongly that the example must be super-complete, having a rough outline for a simple but real query teaches me a lot.

Personally I would also keep the example, as many people as @kuba-- said learn from examples.