search

bblfsh / go-driver

GNU General Public License v3.0
10 stars 9 forks source link

Missing positions in external import parts #55

Closed vmarkovtsev closed 4 years ago

vmarkovtsev commented 5 years ago

Consider this code:

import "gopkg.in/src-d/go-git.v4"

Each leaf in the tree of type uast:Identifier has a Position, but it is not filled. The parent uast:QualifiedIdentifier has it filled, however.

dennwc commented 5 years ago

Yeah, I know where it comes from. The uast:QualifiedIdentifier is synthesized by splitting the import path, so we don't really have those positions from the parser. But it's easy to synthesize positions as well.

vmarkovtsev commented 4 years ago

cc @r0mainK

r0mainK commented 4 years ago

Very cool, will check if it changes anything when I can