search

bblfsh / python-driver

GNU General Public License v3.0
10 stars 16 forks source link

transform failed: column out of bounds: 29 [1, 25] #181

Closed smacker closed 5 years ago

smacker commented 5 years ago

On file: https://github.com/src-d/or-tools/blob/master/examples/python/word_square.py Most probably due to this line: https://github.com/src-d/or-tools/blob/master/examples/python/word_square.py#L121

bblfsh 2.11.8-drivers

dennwc commented 5 years ago

File is not UTF-8. Won't fix.

creachadair commented 5 years ago

File is not UTF-8. Won't fix.

Agreed as far as the functionality, but can we do something to make the error diagnostic more indicative? E.g., when we get a file can we do a quick check for UTF-8 and if it fails, report an error immediately so that the end user knows what happened?

dennwc commented 5 years ago

This happened on bblfshd version that had no check for UTF-8. The new one should return a better error.