Annotations - Githubissues

bblfsh / ruby-driver

GNU General Public License v3.0

3 stars 8 forks source link

Closed juanjux closed 6 years ago

juanjux commented 6 years ago

No Unannotated nodes left.
Ruby AST is peculiar (for example, it overuses "send" for things like binary expressions, function calls, methods, ranges, qualified identifiers...) and also use a lot of node types, so there are currently more "Incomplete" nodes than I would like to. I'll make an UAST improvement proposal soon that should cover a good part of these.
I reviewed manually all integration tests, but there are more than 200+ of those so expect some rough edges.

Fixes #10.

mcuadros commented 6 years ago

@juanjux Native driver test are failling

juanjux commented 6 years ago

@mcuadros I know, just noticed that one of the original native fixtures seems to be broken, I'll fix it.

juanjux commented 6 years ago

cc @vmarkovtsev @mcuadros could you approve this PR if there isn't any other showstopper?