bblfsh / ruby-driver

GNU General Public License v3.0
3 stars 8 forks source link

Don't break with files with just comments. Update Ruby version. #20

Closed juanjux closed 6 years ago

juanjux commented 6 years ago

Fixes #19.

CC @zurk if you want to review to help this be merged quicker.

Signed-off-by: Juanjo Alvarez juanjo@sourced.tech

zurk commented 6 years ago

LGTM, but it is the second time in my life I see Ruby code. The first time was when I created an issue :)

juanjux commented 6 years ago

I also never did any Ruby before writing the driver (well, I think I toyed with Ruby on Rails once, but it was mostly configuration). If you ask me, it looks like Python with ends, some magic, flipflops, and forcing classes down your throat, but that could be me :laughing: