bblfsh / ruby-driver

GNU General Public License v3.0
3 stars 8 forks source link

Error using sdk to build ruby-driver #35

Closed jjhenkel closed 5 years ago

jjhenkel commented 5 years ago

When I run the following command:

$ bblfsh-sdk build jjhenkel/ruby-driver

I'm getting the following output/error:

+ docker build -q -t jjhenkel/ruby-driver .
Step 1/33 : FROM ruby:2.4-alpine3.7 as native
 ---> 0c33cec9d6fb
Step 2/33 : RUN apk add --no-cache make libc-dev gcc
 ---> Using cache
 ---> 5a7208ad6a1b
Step 3/33 : RUN gem install -V --no-document rake bundler io-console parser json
 ---> Running in ae3755d76d5d
ERROR:  Error installing bundler:
    The last version of bundler (>= 0) to support your Ruby & RubyGems was 1.17.3. Try installing it with `gem install bundler -v 1.17.3`
    bundler requires RubyGems version >= 3.0.0. The current RubyGems version is 2.7.8. Try 'gem update --system' to update RubyGems itself.

It looks like I can resolve this error by changing build.yml from:

...
  build:
    deps:
      - 'apk add --no-cache make libc-dev gcc'
      - 'gem install -V --no-document rake bundler io-console parser json'

To:

...
  build:
    deps:
      - 'apk add --no-cache make libc-dev gcc'
      - 'gem install -V --no-document bundler -v 1.17.3 && gem install -V --no-document rake io-console parser json'

Is this a reasonable fix?

dennwc commented 5 years ago

Yes, it definitely makes sense to pin a specific version number there. Can you please file a PR for it?

CC @juanjux