search

bblfsh / sdk

Babelfish driver SDK
GNU General Public License v3.0
23 stars 27 forks source link

Fix edge case for comment parsing #375

Closed dennwc closed 5 years ago

dennwc commented 5 years ago

Comment parser does a correct check for the case when only stylistic characters are present, but it does not set the prefix correctly for this case.

Signed-off-by: Denys Smirnov denys@sourced.tech

bzz commented 5 years ago

If this would result in any fixture changes on the driver update, I suggest mentioning this in SDK release nodes to communicate the expectations to driver developers/maintainers as clearly as possible.

dennwc commented 5 years ago

Yes, it will, but only for this specific edge case. Will update all the drivers and make sure to add a note in the release notes.