search

bblfsh / sdk

Babelfish driver SDK
GNU General Public License v3.0
23 stars 27 forks source link

UAST diff #396

Open dennwc opened 5 years ago

dennwc commented 5 years ago

Supersedes https://github.com/bblfsh/sdk/pull/309. See the original PR for details.

This change is Reviewable

creachadair commented 5 years ago

Before we merge this, we should go through and copy the important parts of the comment thread into the description here IMO.

dennwc commented 5 years ago

Will add those comments as well. It still needs some work as well.

dennwc commented 5 years ago

Rebased on the latest master, also cleaned up the code a bit. Ideally, need at least a few tests that check how the diff output looks like.

bzz commented 5 years ago

Nice job!

Shall we also briefly talk/present only the API that this functionality exposes to the potential users and get their feedback early on, so there are less chances of the need for invasive chances later on?

I know that @Jan21 was using alternative solution for extracting this dataset of structural diffs for every commit https://github.com/src-d/datasets/tree/master/StructuralCommitFeatures so it might make sense to ask @creachadair at next TL meeting to ping ML team to take a quick look, WDYT?

dennwc commented 5 years ago

PR doesn't expose or define any API yet. API is still TBD as well as if we will use this specific diff implementation or not.