search

bblfsh / sdk

Babelfish driver SDK
GNU General Public License v3.0
23 stars 27 forks source link

Refactor the driver manifest (part 1) #399

Closed dennwc closed 5 years ago

dennwc commented 5 years ago

Remove unused manifest fields and get runtime versions from the build manifest.

Previously the runtime and Go versions for the README were derived from the manifest.toml, while the actual driver build (in Dockerfile) was using versions from build.yml. This caused most drivers to be listed as requiring Go 1.12, but in fact, they were still built with Go 1.10. Same happened with native driver versions.

So instead of having random versions in manifest.toml, read them directly from build.yml.

Also, while on it, remove other unused fields in the manifest like OS and "information loss".

This change switches the NativeVersion type from []string to string. It should not affect anything though, because they are no longer read from manifest.toml and it's unlikely that anyone except us was using those fields directly.

The change also includes a workaround for https://github.com/golang/go/issues/28065 to be able to use Go 1.12 in Alpine images.

Signed-off-by: Denys Smirnov denys@sourced.tech

dennwc commented 5 years ago

Ready for another round.

dennwc commented 5 years ago

Renamed fields to *Assets, ready for another round.

dennwc commented 5 years ago

Will wait for @bzz comments as well. Working on part 2 (aliases) in the meantime.