Fixes ChildrenOrder - Githubissues

bblfsh / sdk

Babelfish driver SDK

GNU General Public License v3.0

23 stars 27 forks source link

Fixes ChildrenOrder #422

Closed ncordon closed 5 years ago

ncordon commented 5 years ago

[x] Adds unfolding of arrays in ChildrenOrder. Currently if we had a root with two children son1 and son2, when calling it = root.iterate(ChildrenOrder), we were returned an array [son1, son2] when calling next(it). See #421 for context
[x] Update tests for ChildrenOrder

This change is

ncordon commented 5 years ago

uast/nodes/iter.go, line 236 at r1 (raw file):

Previously, dennwc (Denys Smirnov) wrote…

We can rewrite the switch to: ```golang switch n.Kind() { case KindArray: // unfold case KindObject: // append default: // nothing (values, nil) } ```

Done.