Clarify usage of Default role in switch statements

bblfsh / sdk

Babelfish driver SDK

GNU General Public License v3.0

23 stars 27 forks source link

Clarify usage of Default role in switch statements #427

Closed dennwc closed 5 years ago

dennwc commented 5 years ago

Currently, as noted in https://github.com/bblfsh/php-driver/pull/56#issuecomment-522348679, drivers use the Default role differently in switch statements: some include the Case role, while others omit it when the case is a Default one.

This PR clarifies the usage of Default and requires the Case role to be set as well for switch statements.

Signed-off-by: Denys Smirnov denys@sourced.tech

This change is

ncordon commented 5 years ago

kuba-- commented 5 years ago

Wow, time to try github's CI - travis failed the build:

GET https://api.github.com/repos/bblfsh/go-driver/tags?page=1&per_page=100: 403 API rate limit of 60 still exceeded until 2019-08-22 15:01:41 +0000 UTC, not making remote request.