bblfsh / web

Web client for Babelfish server
http://dashboard.bblf.sh
GNU General Public License v3.0
23 stars 21 forks source link

Improve accessibility of node hover color #116

Closed marnovo closed 6 years ago

marnovo commented 6 years ago

The light-gray hover whenever you hover a node block on the UAST panel on the right is hard to notice in some screens (and/or for some visually impaired people), in contrast to the more obvious yellow color that shows up in the left side.

screen shot 2018-01-15 at 1 33 38 pm

A few solution ideas:

@ricardobaeta may have more interesting solutions.

ricardobaeta commented 6 years ago

@bzz @marnovo

I think it's a pretty straightforward & quick solution. We can/should keep the colour scheme simple and apply the same colour - #ffff00 - but with a very soft Tint variation.

I would go with the smoother Tint of #ffff00

I've looked at the code, and I believe the hot-fix would be something like:

.eckLzy { background: #f9f9f9; background: #ffffe5; }

marnovo commented 6 years ago

@ricardobaeta can you please provide a screenshot with a before/after and tag the users here for a quick validation (Vadim, Alex, Egor, Eiso) before we push this? Thanks.

ricardobaeta commented 6 years ago

@vmarkovtsev @bzz @eiso @EgorBu

Before

image

After

image

vmarkovtsev commented 6 years ago

So much better.

eiso commented 6 years ago

Awesome, thank you