Closed smola closed 6 years ago
👍
do you think it should also include update to https://github.com/src-d/charts/tree/master/bblfsh-dashboard ? \cc @rporres
Took a liberty of adding it to the list
Push bblfsh/dashboard images to Docker Hub.
does it mean pushing it to bbfsh/web
Docker Hub?
just to double-check: would this imply any changes in domain name for a public deployment of the http://dashboard.bblf.sh ?
Any need for name updates in our helm charts for the deployed version?
Comment above updated \w some questions
@bzz I would update them too.
Regarding 3. naming won't change. Besides the long pending request to change it to play.bblf.sh
The idea is that playgrounds are hosted web clients for both gitbase and bblfsh.
do you think it should also include update to https://github.com/src-d/charts/tree/master/bblfsh-dashboard ? \cc @rporres
If there's a change in the name, it should also be reflected in the chart
just to double-check: would this imply any changes in domain name for a public deployment of the http://dashboard.bblf.sh ?
I could set some time to move things to play.bblf.sh considering the whole change
Appreciate it @rporres, it's not time sensitive at all but would be nice to finalize that. I would just also request a 301 redirect from dashboard.bblf.sh to play.bblf.sh too since that link is widely shared.
Overall, looks great to me! Thank you @smola
Marked it as umbrella, as would require at least 2 additional issues on top of administrative work:
Adding to the backlog.
@smola can help with all administrative parts of the rename
@smacker can you please help, taking care of other steps?
It's not clear for me how to update documentation.
Just replace dashboard
by web
would make it weird.
Web for Babelfish server. Babelfish server (v2.5.0 or newer) is required for web. When server starts web will be available on http://localhost:8080 If don't want to run web using our Docker
should we use something like web interface
in documentation or web playground
or ...?
web client
somebody needs to update repo description and tags. I don't have access to do that.
somebody needs to update repo description and tags. I don't have access to do that.
Do not have access either, so @smola please give us a ✋ Added to description
For links and documentation - it's https://docs.sourced.tech/intro/#getting-started-with-babelfish that needs to be updated as well as may be https://doc.bblf.sh/using-babelfish/getting-started.html#using-the-online-dashboard
I'm not sure where the source for that pages comes from. Maybe from docs repo? If so it's fixed already: https://github.com/bblfsh/documentation/pull/194
release: https://github.com/bblfsh/web/releases/tag/v0.7.0 image pushed correctly: https://hub.docker.com/r/bblfsh/web/tags/
Let's drop the word "Dashboard" from the top bar and let's replace the
Huh? Are you sure you run the last version?
@rporres are you going to take care of charts or shall a PR be submitted to src-d/charts by Apps as well? Please let us know!
@bzz As usual, if you need me to do anything please create an issue for it.
There are two tasks here: rename the chart and update terraform configuration to deploy the renamed chart. I definitely have to do the second part as you're not familiar with it. The chart renaming is up to you: you can send me a PR (as you did with gitbase) or you can create a rename-deployment issue
Sounds good!
@smacker can you please submit a PR to chart as well as it seems to be the last action item in here?
@bzz Thx for taking care of the chart.
The last action item will be to deploy the renamed chart. Please create an issue for that as well and I will take care of it
Change of the domain is not related to this issue and is tracked in the separate issue linked above.
@smacker I think it's ok to take a risk and I'm sure @rporres would be happy to review the chart changes, same as he did for @carlosms who took care of updating gitbase-web, but if in doubt please follow the advice above https://github.com/bblfsh/web/issues/149#issuecomment-414615044
I'm not talking about the domain here, @bzz. Since there's a chart name change, I will need to update the terraform configuration related to the change and that will trigger a new deployment.
I've created https://github.com/src-d/issues-infrastructure/issues/215 to take care of that.
pr to charts: https://github.com/src-d/charts/pull/67
pr to charts: src-d/charts#67
Merged. Now it's on me to deploy it
For
Check links from documentation of other projects.
@eiso just to double-check, would the same logic be applicable here, as it https://github.com/src-d/gitbase-web/issues/218#issuecomment-414832903 ?
Yes
bblfsh-dashboard
->bblfsh-web
@bzz Before doing any of the changes, let's double check that the task list is comprehensive.