UAST2 - Githubissues

bblfsh / web

Web client for Babelfish server

http://dashboard.bblf.sh

GNU General Public License v3.0

23 stars 21 forks source link

UAST2 #160

Closed smacker closed 5 years ago

smacker commented 5 years ago

Requires new uast-viewer with uast2 support. (https://github.com/bblfsh/uast-viewer/pull/63 should be merged)

TODO:

[x] release new uast-viewer and update version here
[x] fix tests
[x] manual testing

Code is ready for review

carlosms commented 5 years ago

LGTM so far

smacker commented 5 years ago

After manual testing of everything I could find only 1 bug: we lost the ability to report that a driver can't parse source code.

Here is an issue and comment about it in client-go: https://github.com/bblfsh/client-go/issues/82#issuecomment-431024304

According to LA team, it's impossible right now to tell was it driver error or not. I think it shouldn't be a blocker for this PR but should be blocker for the release.

smacker commented 5 years ago

2 new issues about errors:

https://github.com/bblfsh/web/issues/162 introduced here
https://github.com/bblfsh/web/issues/163 broken in current master

smacker commented 5 years ago

Tests are fixed
Uast-viewer released
Manual testing is done (found 2 issues, will be fixed separately, look at the prev comment)
CI is fixed

@carlosms @smola please another look.

carlosms commented 5 years ago

Approve (review button does not work, github is not working great today)

smacker commented 5 years ago

there is one more bug but it will be fixed by updating uast-viewer version. (as soon as github webhooks come back to life) It's better to re-test new version with both this changes and the ones about errors. Merging.