search

bblfsh / web

Web client for Babelfish server
http://dashboard.bblf.sh
GNU General Public License v3.0
23 stars 21 forks source link

Don't commit assets #199

Closed smacker closed 5 years ago

smacker commented 5 years ago

fix #192

Now it works the same as any other apps project. I also replaced bindata with esc. static_files_dev.go & static_files.go are 100% copy-paste from lookout-web.

Makefile still looks a bit strange but changing it is out of the scope.

carlosms commented 5 years ago

It's tested this locally, and for me make build & make serve fail if the dir ./server/asset does not exist. When the dir exists, make serve works, but make packages creates a bin serving the 501 errors.

smacker commented 5 years ago

thanks for testing! I'll re-test with a clean state.

carlosms commented 5 years ago

Also if it's not too complex it would be good to test it in travis. Maybe a make packages, run the bin in the background, and then check the wget localhost:port exit code.

smacker commented 5 years ago

good idea! 👍

smacker commented 5 years ago
  1. I added mkdir -p to make sure directory always exists
  2. I can't reproduce the problem with make packages. This command and make build on clean repository generate correct binary with assets included.
  3. I added simple integration test with check for correct content in / path
  4. Had to rebase because asset.go was changed in master
dpordomingo commented 5 years ago

pretty good idea adding integration tests ! :tada: