search

bbloomf / jgabc

http://bbloomf.github.io/jgabc/
The Unlicense
100 stars 48 forks source link

Adds Solesmes lengthening to salicus, distropha, tristropha, and pressus #38

Closed nate-g closed 5 years ago

nate-g commented 5 years ago

The goal of these changes are to add the lengthening specified in the Solesmes guide that can be found in the Liber. Namely:

1) Salicus: the middle note of a ascending group with an episema below it should be elongated. 2) Distropha and Tristropha should be sung as a single value of double or triple length, respectively. 3) Two notes joined on the same pitch and syllable form a pressus which is sung as one note of double length.

Since not all users will want to use these rules, I've added a new flag to the propers page, "Use Solesmes length for salicus, pressus, distropha and tristropha". If checked, these rules will be implemented on chants played within the propers page. If not checked, the rules will be ignored and play should operate as they currently are. Pages other than the propers page should not be affected.

bbloomf commented 5 years ago

I have actually often made the same typo myself, but the Abbey is called Solesmes rather than Solemnes.

I will look at this on Monday. Thanks!

nate-g commented 5 years ago

Ah, I could have sworn I spelled it as you did, but I see you're correct! I'll correct that this weekend.

On Sat, Jun 22, 2019, 8:43 PM Benjamin Bloomfield notifications@github.com wrote:

I have actually often made the same typo myself, but the Abbey is called Solesmes rather than Solemnes.

I will look at this on Monday. Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bbloomf/jgabc/pull/38?email_source=notifications&email_token=AIGDFWS44Z55YU4WSDOEQILP33BLTA5CNFSM4H2XGYY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYKT77Q#issuecomment-504709118, or mute the thread https://github.com/notifications/unsubscribe-auth/AIGDFWXZKBSODWLGQMJGGVLP33BLTANCNFSM4H2XGYYQ .

nate-g commented 5 years ago

Just a note on this. With this PR, any pressus with a distropha (e.g. a distropha followed by a clivis where the one is on the second note of the clivis) is not considered a pressus and will be repercussed.