search

bbloomf / jgabc

http://bbloomf.github.io/jgabc/
The Unlicense
100 stars 48 forks source link

Replace mode annotation in propers tool #66

Closed Kljunas2 closed 1 year ago

Kljunas2 commented 1 year ago

Mode annotation when using psalm toned propers was incorrect if the mode has beend changed.

bbloomf commented 1 year ago

This should be fixed now

Kljunas2 commented 1 year ago

Neither github.io page nor fresh git clone show proper tones in annotations. Is there something I am missing? In the image, I have chosen the third mode for introitus, melody is correct, while annotation still says VII. image

bbloomf commented 1 year ago

I forgot to push my commit. It should be up there now.

Sorry!

On Mon, Jan 23, 2023 at 9:57 AM Miha Korenjak @.***> wrote:

Neither github.io page nor fresh git clone do not show proper tones in annotations. Is there something I am missing? In the image, I have chosen the third mode for introitus, melody is correct, while annotation still says VII. [image: image] https://user-images.githubusercontent.com/17785580/214071287-27152845-3ee5-48b9-868f-eefef8366311.png

— Reply to this email directly, view it on GitHub https://github.com/bbloomf/jgabc/pull/66#issuecomment-1400488816, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHBPSYGQWTPZCLD75MJ3ZDWT2L6RANCNFSM6AAAAAAUDB6U24 . You are receiving this because you modified the open/close state.Message ID: @.***>

Kljunas2 commented 1 year ago

It works now, thanks.