Improve building proccess

gtsiam commented 3 years ago

Oh, I'm the first PR! And I love this idea so I really hope it succeeds!

This is a laundry list of changes that (I think) should be made to the build system + updated documentation for running locally.

In detail:

Moved profile settings to root Cargo.toml. wasm-pack was warning that they were being ignored where they were.
Committed a version of Cargo.lock. This should be included in standalone apps, since it ensures reproducible builds.
Added a rust-toolchain file. This will take care so that everything is build with rustc nightly-2020-11-17. Given the feature macros, I assume you're using nightly either way. Also the nightly version is just one where I know it builds, so I'm locking it there. It can just be updated periodically.
Removed an unused package.json, since there is no js code to begin with.

Lastly, regarding the documentation changes:

I'm linking to official installation instructions to deal with different platforms. I assume most developers have at least rustup and npm installed already, so I doubt the one remaining link would be a major turnoff.
The link in the instructions now links straight to the app. (localhost:5000/notecalc)
I'm not using npx, as per https://github.com/bbodi/notecalc3/issues/1#issuecomment-730509331, since it has to download serve every time it runs - Honestly, this is still up for discussion.

Closes #1.

bbodi commented 3 years ago

Thanks a lot, a lot of useful changes were added here :)

gtsiam commented 3 years ago

Happy to help :)

But you know that moment of dread when you realize a mistake?

The link on the Readme is one of those... I wrote:

[...]
Then, open your browser and go to  [http://localhost:5000/notecalc]().

Thinking it would just delimit from the period, but it messes up the link.

I'm not sure how easy reverting is on the ui, it would probably be easier to just make a new commit fixing the issue.

bbodi commented 3 years ago

I'm not sure how easy reverting is on the ui, it would probably be easier to just make a new commit fixing the issue. Yeah no worries, just do that :)

bbodi / notecalc3

Improve building proccess #3