bbogush / nand_programmer

NANDO - NAND Open programmer
GNU General Public License v3.0
316 stars 119 forks source link

Wrong timing calculation code? #47

Closed 7134956 closed 2 years ago

7134956 commented 2 years ago

https://github.com/bbogush/nand_programmer/blob/7f0379c779699122d7c1a9685d2fd52b0a425df7/qt/parallel_chip_info.cpp#L56 https://github.com/bbogush/nand_programmer/blob/7f0379c779699122d7c1a9685d2fd52b0a425df7/qt/parallel_chip_info.cpp#L59 https://github.com/bbogush/nand_programmer/blob/7f0379c779699122d7c1a9685d2fd52b0a425df7/qt/parallel_chip_info.cpp#L64 https://github.com/bbogush/nand_programmer/blob/7f0379c779699122d7c1a9685d2fd52b0a425df7/qt/parallel_chip_info.cpp#L83 This does not match the appnote. tCH or tCS.

https://github.com/bbogush/nand_programmer/blob/7f0379c779699122d7c1a9685d2fd52b0a425df7/qt/parallel_chip_info.cpp#L72 waitSetupTime = std::max(params[CHIP_PARAM_T_WP], params[CHIP_PARAMTRP]);

image

This is how my samsung chips read fine: https://github.com/7134956/nand_programmer/commit/6ec011dd5dfe07d47d72442f6874e349159a63fc

bbogush commented 2 years ago

Good catch. Thank you!